Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented option for comma separated slice data #3

Closed
wants to merge 3 commits into from
Closed

Implemented option for comma separated slice data #3

wants to merge 3 commits into from

Conversation

Southclaws
Copy link

@Southclaws Southclaws commented Oct 21, 2018

Resolves #2

  • Encoding struct fields with comma option set results in a single parameter with comma separated values. It's the most basic implementation and will not attempt to escape commas that exist within strings.
  • Decoding struct fields with comma option set will treat input as a single url.Values item and run strings.Split on it to produce an iterable for conversion. Will not attempt to handle escaped commas within strings. Only tested with primitive types.
  • Documented changes underneath the omitempty note.

@mariusor
Copy link

Probably you meant to reference the issue #2, not PR #1.

Also it seems that the project is somewhat abandoned. I didn't get as much as a ping from the owners for my PR opened more than a month ago.

@Southclaws
Copy link
Author

Yeah I forgot to check the repo activity!

In that case, feel free to PR your addition to my fork, might as well keep a single copy for future users.

update readme with a maintenance notice and new import paths
add go.mod file
@Southclaws Southclaws closed this Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants